You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
these attributes are applied to the wrapper <div> instead of the input element.
While the documentation mentions an "inputId" prop for the input's id, this approach is counterintuitive.
Using passthrough for this purpose is just "too much", it just doesn't make sense.
The Password component is fundamentally an input component,
and the <div> wrapper should be considered a helper element.
It's very unlikely that users would intentionally want to assign html attributes to this wrapper. primefaces/primevue/#5447
I propose that basic INPUT attributes should be passed directly to the input element.
and wrapper div's attributes should be passed with something like "wrapperAttrs".
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The current implementation of the Password component wraps the input element in a
<div>
.When using the component like
these attributes are applied to the wrapper
![image](https://private-user-images.githubusercontent.com/38183949/350673289-2170839d-1af8-4577-9255-befc666137ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MDAxMjEsIm5iZiI6MTcyNTU5OTgyMSwicGF0aCI6Ii8zODE4Mzk0OS8zNTA2NzMyODktMjE3MDgzOWQtMWFmOC00NTc3LTkyNTUtYmVmYzY2NjEzN2JhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA1MTcwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhNTA5YzBjOTA4ZDFiYmQ0ZTQ0MDk4ZWU2MzQ1NTMzOTc1MGNlYzE5NDEzNmE3NGRkNGQzNDZlNjcwNmViZDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WUFGpcOE24HmMqOntKTwluWBy1bJtOUpImoLrb6AdLQ)
<div>
instead of the input element.While the documentation mentions an "inputId" prop for the input's id, this approach is counterintuitive.
Using passthrough for this purpose is just "too much", it just doesn't make sense.
The Password component is fundamentally an input component,
and the
<div>
wrapper should be considered a helper element.It's very unlikely that users would intentionally want to assign html attributes to this wrapper.
primefaces/primevue/#5447
I propose that basic INPUT attributes should be passed directly to the input element.
and wrapper div's attributes should be passed with something like "wrapperAttrs".
Beta Was this translation helpful? Give feedback.
All reactions