Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admit different types for a group and a subgroup of it. #1838

Closed
ThomasBreuer opened this issue Dec 22, 2022 · 2 comments
Closed

Admit different types for a group and a subgroup of it. #1838

ThomasBreuer opened this issue Dec 22, 2022 · 2 comments
Labels
enhancement New feature or request topic: groups

Comments

@ThomasBreuer
Copy link
Member

Currently subgroups of a given group G are constructed via _as_subgroup -> _as_subgroup_bare -> _oscar_group.
This implies that the subgroup gets the same Julia type as G.
(See #1836 for an example where this rule causes difficulties.)

Eventually it may be useful to admit other types for subgroups. Since all subgroup constructions come together with an embedding homomorphism, there is no problem with such a more general setup.

@ThomasBreuer ThomasBreuer added enhancement New feature or request topic: groups labels Dec 22, 2022
@lgoettgens
Copy link
Member

Is this resolved by the introduction of SubPcGroup and SubFpGroup?

@ThomasBreuer
Copy link
Member Author

Yes, the issue is resolved.
The solution was to introduce _sub_type in order to define a map from the type of a group to the type of its subgroups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: groups
Projects
None yet
Development

No branches or pull requests

2 participants