Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour variables to SVGs #113

Open
samrichca opened this issue Jan 27, 2021 · 1 comment
Open

Add colour variables to SVGs #113

samrichca opened this issue Jan 27, 2021 · 1 comment
Labels

Comments

@samrichca
Copy link
Member

SVGs on Overture.bio (i.e. in the Icon component) currently have hard-coded colour hex codes. Using CSS variables to define the colours (with a fallback for Edge) would ensure better visual consistency and reduce the level of effort for future maintenance.

@samrichca
Copy link
Member Author

samrichca commented Jan 28, 2021

we could change the SVG files to JSX so they take props & colour schemes, and use styled components or CSS-in-JS, similar to ego, argo, etc:

https://github.com/overture-stack/ego-ui/pull/118/files

changing the components and where styling is located would impact this ticket:

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant