Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Preserve file extension when creating new files (Document Scanner, App Provider etc) #1292

Closed
9 tasks
michaelstingl opened this issue Nov 13, 2023 · 3 comments · Fixed by #1298
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Nov 13, 2023

Is your feature request related to a problem? Please describe.
We received user feedback, that users changed the file extension when creating new files (Document Scanner, App Provider etc), so they experienced issues later when they tried to work with this files.

Describe the solution you'd like
In cases, where users create new files of a specific file type, the input field should not allow to change or remove the file extension. Advanced users could always change the file extension later with the "Rename" file action.

Describe alternatives you've considered
n.a.

Additional context

IMG_0216 IMG_0218
➕ > New document ➕ > Scan document
ownCloud release version 12.0.3 build 282 (Tue Aug 29 16:54:13 CEST 2023)
(app: v12.0.3 - milestone/12.0.3@40dfc92f, sdk: v12.0.3 - develop@740b63e)

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@michaelstingl michaelstingl added this to the 12.2-Next milestone Nov 13, 2023
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Nov 13, 2023
@michaelstingl
Copy link
Contributor Author

Describe alternatives you've considered
n.a.

@felix-schwarz proposed a simpler implementation, and only display a warning message that asks for user confirmation.

…and make document scanner filename pre-selected, similar as the "New document" behavior.

@felix-schwarz
Copy link
Contributor

I eventually ended up implementing a re-usable UITextField subclass that can directly enforce a file extension by dropping all changes and selection to the file extension portion: #1298

@jesmrec jesmrec mentioned this issue Nov 17, 2023
36 tasks
@michaelstingl michaelstingl linked a pull request Nov 27, 2023 that will close this issue
5 tasks
@jesmrec
Copy link
Contributor

jesmrec commented Nov 28, 2023

Done. Ready to 12.1

@jesmrec jesmrec closed this as completed Nov 28, 2023
@jesmrec jesmrec mentioned this issue Apr 24, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants