Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI / PDF] Full screen view for PDFs #428

Closed
michaelstingl opened this issue Jun 30, 2019 · 4 comments · Fixed by #813
Closed

[UI / PDF] Full screen view for PDFs #428

michaelstingl opened this issue Jun 30, 2019 · 4 comments · Fixed by #813
Assignees
Milestone

Comments

@michaelstingl
Copy link
Contributor

In the PDF view, the toolbar is always shown and the miniatures are always shown. Many PDF viewers can switch to a fullscreen view…

@michaelstingl michaelstingl added this to the 11.5.0-Next milestone Jul 6, 2020
@mneuwert
Copy link
Contributor

mneuwert commented Oct 5, 2020

@michaelstingl Played around with adding tap gesture recognisers and came to the conclusion:

  • We can add tap to full-screen
  • But we will loose double tap zoom... And that's not easy to fix. Tried some hacky approaches but failed so far..

@michaelstingl
Copy link
Contributor Author

  • But we will loose double tap zoom... And that's not easy to fix. Tried some hacky approaches but failed so far..

Try that with the 11.5 TestFlights, maybe with the 11.5 stable as well, then wait for user feedback? We can always revert…

@mneuwert
Copy link
Contributor

mneuwert commented Oct 9, 2020

@michaelstingl @hosy Changed couple of things due to issues with thumbnail view which sort of started behaving correctly on iOS13, before it has been behaving pretty badly causing all sorts of crashes when it's properties (layout, thumbnail size) have been changed dynamically. So, I decided to provide cool stuff on iOS 13 or higher:

  • Full screen when PDF view is tapped
  • Dynamically adapting thumbnail sizes
  • Vertical thumbnail strip in landscape on iPhone (compact vertical size class).
  • Background colour of thumbnail strip matching system default PDF view background color which is nicer than the one used prior to iOS 13

@jesmrec
Copy link
Contributor

jesmrec commented Dec 15, 2020

Done

@jesmrec jesmrec closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants