Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scrypt,bcrypt or argon2 for password hashing? #510

Closed
IljaN opened this issue Aug 31, 2020 · 1 comment
Closed

Use scrypt,bcrypt or argon2 for password hashing? #510

IljaN opened this issue Aug 31, 2020 · 1 comment
Assignees
@C0rby

Comments

@IljaN
Copy link
Member

IljaN commented Aug 31, 2020

We currently use shacrypt https://github.com/tredoe/osutil/blob/master/user/crypt/sha512_crypt/sha512_crypt.go#L12 which is a variant of unix crypt: https://en.wikipedia.org/wiki/Crypt_(C)

From Wikipedia:

Ulrich Drepper, the glibc maintainer, rejected bcrypt (scheme 2) support since it isn't approved by NIST.

More info here: https://access.redhat.com/articles/1519843

Do we need NIST compliance?
@IljaN IljaN mentioned this issue Sep 7, 2020
Closed
2 tasks
@IljaN
Copy link
Member Author

IljaN commented Sep 15, 2020

Rationale to use bcrypt: Even if sha512 crypt might be relatively secure it is not widely used even less so with the golang implementation.

@IljaN IljaN closed this as completed Sep 28, 2020
@micbar micbar mentioned this issue Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IljaN @C0rby