Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] Reworking lock tests #7625

Closed
7 tasks done
ScharfViktor opened this issue Oct 30, 2023 · 4 comments
Closed
7 tasks done

[test-only] Reworking lock tests #7625

ScharfViktor opened this issue Oct 30, 2023 · 4 comments
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 30, 2023

I started to rework lock tests, see here #7595 and #7624

need rework tests from:

next test

collecting bug:

CC @saw-jan

@SwikritiT
Copy link
Contributor

The only feature remaining in tests/acceptance/features/coreApiWebdavLocks is https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavLocks/requestsWithToken.feature
which is failing because share lock is not implemented as described in #7599, @ScharfViktor I'll leave it as it is for now or would you recommend to move it as well?

@ScharfViktor
Copy link
Contributor Author

The only feature remaining in tests/acceptance/features/coreApiWebdavLocks is https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavLocks/requestsWithToken.feature which is failing because share lock is not implemented as described in #7599, @ScharfViktor I'll leave it as it is for now or would you recommend to move it as well?

I guess this case won't work because sharee cannot shared resource if sharer already locked it. like this case: https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/lockFiles.feature#L219

@SwikritiT
Copy link
Contributor

@ScharfViktor all the checklists have been done. Can you go through the tests and make sure that there is proper test coverage or mention if we need to add more tests?

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor all the checklists have been done. Can you go through the tests and make sure that there is proper test coverage or mention if we need to add more tests?

Looks great. Thanks for your care 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants