Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make space templates production ready #8713

Closed
kobergj opened this issue Mar 21, 2024 · 11 comments · Fixed by #8723
Closed

Make space templates production ready #8713

kobergj opened this issue Mar 21, 2024 · 11 comments · Fixed by #8723
Assignees
Labels

Comments

@kobergj
Copy link
Collaborator

kobergj commented Mar 21, 2024

Just so I don't forget details.

Needs rework:

  • readme.md must be translated
  • image not good, color should be #4c5f79; ratio should be 16:9
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 21, 2024

After we create a space, the quota field is missing a lot of data

remaining: 999996097
state: "normal"
total: 1000000000
used: 3903

We need all of these attributes ^ this is blocking

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 21, 2024

This should be sufficient
untitled (2)

svg content

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none" width="16" height="9">
    <!-- Transparent padding -->
    <rect x="0" y="0" width="24" height="24" fill="none"/>
    <g transform="translate(4 4) scale(0.7)">
        <!-- Original content -->
        <path d="M22 12.999V20C22 20.5523 21.5523 21 21 21H13V12.999H22ZM11 12.999V21H3C2.44772 21 2 20.5523 2 20V12.999H11ZM11 3V10.999H2V4C2 3.44772 2.44772 3 3 3H11ZM21 3C21.5523 3 22 3.44772 22 4V10.999H13V3H21Z" fill="#4c5f79"/>
    </g>
</svg>

</svg>

is this ok for you @tbsbdr ?
image

I also have an alternate version with slightly larger icons, but I like the one above more, please decide
image

@tbsbdr
Copy link
Contributor

tbsbdr commented Mar 21, 2024

the one with the smaller icons, agree

@AlexAndBear
Copy link
Contributor

@kobergj that means you can use the provided png

@TheOneRing
Copy link
Member

TheOneRing commented Mar 21, 2024

The 16:9 is hand tailored for the web client.
Can we at least try to be a bit more agnostic?

@AlexAndBear
Copy link
Contributor

The 16:9 is hand tailored for the web client.

Can we at least try to be a bit more agnostic?

Sure, open for any suggestions.
I feel that we need to touch the thumbnail/preview service if we want to have the original images in a 1:1 aspect ratio but keep up the landscape mode representation in web. Same goes for the emoji images.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 22, 2024

@TheOneRing just after seeing your implementation in the demos 👏 , I think it could be also quite fitting to have the 16:9 landscape representation on the desktop client, do you think otherwise?

@TheOneRing
Copy link
Member

Users will upload any format, I'm not a fan of randomly cropping the image.
For the desktop, increasing the space for the image, would reduce the space available for the progress and upload information.
image

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 22, 2024

I think we need to discuss this in a bigger round, especially with @tbsbdr to find out, what we should do then across all clients.
We agreed on the 16:9 banner format for space images as we started this feature, maybe it's time to change this or try to find a solution, so that web will be able to display the space image, I provided, in the 16:9 aspect ratio format, even if its 1:1 ratio on the server, or vice versa.
I don't think we will come to a conclusion here

@kulmann
Copy link
Member

kulmann commented Mar 22, 2024

The 16:9 is hand tailored for the web client.
Can we at least try to be a bit more agnostic?

It's not tailored for the web client. I asked for feedback here owncloud/web#10546 (comment) and apparently at least the iOS client is happy about a 16:9 aspect ratio. 😉

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Mar 22, 2024

Here is a future proposal, to make the space image/readme upload process even more convenient
#8719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants