Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assimilate clean command into sessions #9003

Open
kobergj opened this issue Apr 29, 2024 · 7 comments · Fixed by #9041
Open

Assimilate clean command into sessions #9003

kobergj opened this issue Apr 29, 2024 · 7 comments · Fixed by #9041
Assignees

Comments

@kobergj
Copy link
Collaborator

kobergj commented Apr 29, 2024

ocis storage-users uploads clean cleans up unfinished uploads when executed.

ocis storage-users uploads sessions lists unfinished uploads. It takes filters to only list specific uploads (e.g. processing=true). It already has a --restart flag that restarts listed uploads. If we deprecate the clean command and add a --clean flag to the sessions command instead, we will use the same logic on both commands.

Acceptance Criteria:

  • deprecate ocis storage-users uploads clean
  • add a --clean flag and logic to sessions command
  • make sure virus infected files can be filtered in some way
@micbar
Copy link
Contributor

micbar commented May 3, 2024

@d7oc @kobergj Should we backport this?

When it fits into a patch release, i think it would be worth a backport.

@micbar micbar reopened this May 3, 2024
@kobergj
Copy link
Collaborator Author

kobergj commented May 3, 2024

If we want it: Full feature would need another reva release.

@d7oc
Copy link
Contributor

d7oc commented May 3, 2024

I would really appreciate a backport.

@tbsbdr
Copy link
Contributor

tbsbdr commented May 27, 2024

@d7oc is the current solution which is currently rolled out "good enough"? (we would prefer not to backport with efforts in mind)

@d7oc
Copy link
Contributor

d7oc commented May 27, 2024

No backport means we would get it when according to the current planning?

@kobergj
Copy link
Collaborator Author

kobergj commented Aug 14, 2024

Still not clear if this needs to be backported. If not backported this feature will only come with ocis 6.x

@tbsbdr @d7oc please decide so I can either close this ticket or proceed with the backport

@d7oc
Copy link
Contributor

d7oc commented Aug 14, 2024

IMHO we should do a back port. oCIS 6 will otherwise take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants