Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service registry regression on nats-js-kv #9382

Closed
wkloucek opened this issue Jun 14, 2024 · 2 comments · Fixed by #9385
Closed

service registry regression on nats-js-kv #9382

wkloucek opened this issue Jun 14, 2024 · 2 comments · Fixed by #9385

Comments

@wkloucek
Copy link
Contributor

Describe the bug

I discovered that one can't mix and match oCIS 5.0.5 and latest because services will not find each other.

Steps to reproduce

  1. start oCIS Helm Chart deployment example with NATS (default tag 5.0.5)
  2. exec into nats-box and list the service-registry bucket
  3. update oCIS to latest tag
  4. exec into nats-box and list the service-registry bucket

Expected behavior

For oCIS 5.0.5 and latest the output is all base32 encoded:

This is how it looks for oCIS 5.0.5:

~ # nats kv  ls service-registry
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTORXXEYLHMUWXG2DBOJSXG===
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTHMF2GK53BPE======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTGOJXW45DFNZSA====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTVONSXE4Y=
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTORXXEYLHMUWXA5LCNRUWG3DJNZVQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTORXXEYLHMUWXG6LTORSW2===
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTTORXXEYLHMUWXG6LTORSW2===
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTPMNSGC5Q=
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTBOV2GQLLTMVZHM2LDMU======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTBOBYC24TFM5UXG5DSPE======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTORXXEYLHMUWXK43FOJZQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTHOJXXK4DT
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTXMVRGM2LOM5SXE===
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTBOV2GQLLNMFRWQ2LOMU======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTNBQXE2LOM4======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTPMNZQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTUNB2W2YTOMFUWY4Y=
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTUNB2W2YTOMFUWY4Y=
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTMVQXEY3I
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTXMVRGIYLW
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTXMVRA====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTTMV2HI2LOM5ZQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTTMV2HI2LOM5ZQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOMFYGSLTFOZSW45DINFZXI33SPE======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOM5ZGC4DIFZTXEYLQNA======
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTQOJXXQ6I=
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOOVZWK4TMN5TS45LTMVZGY33H
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOONZWKLTTONSQ====
ONSXE5TJMNSS24TFM5UXG5DSPFPWG33NFZXXO3TDNRXXKZBOO5SWELTJMRYA====

Actual behavior

This is how it looks on latest:

~ # nats kv  ls service-registry
service-registry_com.owncloud.api.auth-machine
service-registry_com.owncloud.api.app-registry
service-registry_com.owncloud.api.gateway
service-registry_com.owncloud.api.auth-service
service-registry_com.owncloud.web.frontend
service-registry_com.owncloud.api.groups
service-registry_com.owncloud.web.ocdav
service-registry_com.owncloud.api.sharing
service-registry_com.owncloud.api.storage-publiclink
service-registry_com.owncloud.api.storage-shares
service-registry_com.owncloud.api.storage-system
service-registry_com.owncloud.web.storage-system
service-registry_com.owncloud.api.storage-users
service-registry_com.owncloud.web.thumbnails
service-registry_com.owncloud.api.thumbnails
service-registry_com.owncloud.web.userlog
service-registry_com.owncloud.api.users
service-registry_com.owncloud.web.webdav
service-registry_com.owncloud.web.web
service-registry_com.owncloud.web.webfinger
service-registry_com.owncloud.web.idp
service-registry_com.owncloud.api.search
service-registry_com.owncloud.api.eventhistory
service-registry_com.owncloud.web.graph
service-registry_com.owncloud.web.proxy
service-registry_com.owncloud.web.ocs
service-registry_com.owncloud.sse.sse
service-registry_com.owncloud.web.settings
service-registry_com.owncloud.api.settings

Setup

see description

Additional context

Some names are actually expected to be changed (but not removing the base32 decoding): #9149

There were some changes around encoding: cs3org/reva#4678

@micbar
Copy link
Contributor

micbar commented Jun 14, 2024

@kobergj

@kobergj
Copy link
Collaborator

kobergj commented Jun 14, 2024

@wkloucek thanks ❤️ I thought we fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants