Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification can't send mails if the displayname has a comma #9402

Closed
b1schumacher opened this issue Jun 18, 2024 · 2 comments · Fixed by #9468
Closed

notification can't send mails if the displayname has a comma #9402

b1schumacher opened this issue Jun 18, 2024 · 2 comments · Fixed by #9468
Assignees
Labels

Comments

@b1schumacher
Copy link

b1schumacher commented Jun 18, 2024

Describe the bug

If the display name of a user has a comma, the notification service can't send a mail, because the sender is not in commas which has to be with a comma in the string.

Steps to reproduce

  1. Change the display name to "Tux, Eberhard"
  2. Send a Mail via the notification

Expected behavior

Mails should be send from this user.

Actual behavior

Mails are not send and have a error in the notifications logs

{"level":"error","service":"notifications","error":"Mail Error: mail: missing '@' or angle-addr; Header: [From] Address: [Tux, Eberhard via [email protected]]","e
vent":"SendEmail","time":"2024-06-14T16:06:31Z","line":"github.com/owncloud/ocis/v2/services/notifications/pkg/service/service.go:129","message":"failed to send a message"}

Setup

OCIS 5.0.5 with helm charts deployed

Additional context

@2403905
Copy link
Contributor

2403905 commented Jun 20, 2024

@b1schumacher Thank you for your report. I'll take a look ASAP.

@2403905 2403905 self-assigned this Jun 20, 2024
@blicknix
Copy link

@2403905 There is already a merge request which fixes this #9403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants