Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocis backup consistency --fail option #9411

Closed
wkloucek opened this issue Jun 19, 2024 · 2 comments · Fixed by #9447
Closed

ocis backup consistency --fail option #9411

wkloucek opened this issue Jun 19, 2024 · 2 comments · Fixed by #9447
Assignees

Comments

@wkloucek
Copy link
Contributor

Is your feature request related to a problem? Please describe.

ocis backup consistency should have a ´--fail` option where exits with a non zero exit code if it finds inconsistencies.

Describe the solution you'd like

If the --fail flag is provided and inconsistencies are found, the exit could is != 0, eg 1.

Describe alternatives you've considered

Parse the log output for strings indicating that inconsistencies have been found but that is somehow error prone since those strings could change over time.

Additional context

Maybe this is similiar to the --fail option of curl (see https://curl.se/docs/manpage.html#-f)

cc @kobergj

@kobergj
Copy link
Collaborator

kobergj commented Jun 19, 2024

Should be fairly easy implementable. The curl manpage mentions it returns status code 22. Should we also return a special status code? Or we just go with generic 1?

@wkloucek
Copy link
Contributor Author

Or we just go with generic 1?

1 would be fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants