Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] cleanup test feature file for @skiponRevaMaster tag #9451

Closed
S-Panta opened this issue Jun 24, 2024 · 3 comments
Closed

[QA] cleanup test feature file for @skiponRevaMaster tag #9451

S-Panta opened this issue Jun 24, 2024 · 3 comments
Labels

Comments

@S-Panta
Copy link
Contributor

S-Panta commented Jun 24, 2024

Currently, we bump oCIS test only on Reva-edge. In the drone config, skiponReva is used to skip those tests on edge. Therefore using the @skiponrevamaster tag is redundant since the tag isn't used in the edge branch.

reva edge drone config file:

 "BEHAT_FILTER_TAGS": "~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@provisioning_api-app-required&&~@preview-extension-required&&~@local_storage&&~@skipOnOcis-OCIS-Storage&&~@skipOnGraph&&~@caldav&&~@carddav&&~@skipOnReva&&~@env-config",
@S-Panta
Copy link
Contributor Author

S-Panta commented Jun 24, 2024

@phil-davis Can we clean this tag?

@phil-davis
Copy link
Contributor

@phil-davis Can we clean this tag?

Yes, it is old history. The current tests are aimed at the behavior of reva edge, and ocis. The behavior of reva master will be quite different. We have not been running on reva master for a long time, so we have no idea which scenarios would need this tag anyway.

Delete the tag.

@amrita-shrestha
Copy link
Contributor

@S-Panta duplication of #5337 so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants