Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs discussion] Bump of rs/cors and resulting issues #9527

Closed
dragonchaser opened this issue Jul 4, 2024 · 4 comments
Closed

[Needs discussion] Bump of rs/cors and resulting issues #9527

dragonchaser opened this issue Jul 4, 2024 · 4 comments
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Topic:Security

Comments

@dragonchaser
Copy link
Member

dragonchaser commented Jul 4, 2024

Due to changes in rs/cors (rs/cors@4c32059#diff-bf80d8fbedf172fab9ba2604da7f7be972e48b2f78a8d0cd21619d5f93665895R367) we have a security issue that would cause some fallout in ALL clients. This security issue is valid and the fix in rs/cors needed, but the acceptance-factor in the community and developers of projects attached should be zero.

The change requires all Access-Control-Request-Headers to be lower-case and in alphabetical order.

We tried to enforce this in #9518 but realized that his might break ALL clients (web, desktop...)

Can we come up with a roadmap how to implement this?

For now we suggest the following:

  • silence those security issues in the vulnerability scanner (go vuln-check) if possible
  • merge all release relevant PRs to unblock us
  • wait for clients to adapt the changes and then merge the remainders of bump reva #9518

@TheOneRing @kulmann @micbar @dragotin can you please join the discussion on this since you are directly affected.

Client Affected
Web unknown
Moodle integration unknown
Desktop client unknown
@dragonchaser dragonchaser added Topic:Security Priority:p1-urgent Consider a hotfix release with only that fix labels Jul 4, 2024
@dragonchaser
Copy link
Member Author

Silencing is not possible, see: golang/go#61211 we might have to disable the step in the pipeline.

@dragonchaser dragonchaser mentioned this issue Jul 4, 2024
@dragonchaser dragonchaser changed the title Bump of rs/cors and resulting issues [Needs discussion] Bump of rs/cors and resulting issues Jul 5, 2024
@2403905
Copy link
Contributor

2403905 commented Jul 11, 2024

I noticed that after bumping the upload of the big files became broken. We should keep an eye on it.

@butonic
Copy link
Member

butonic commented Jul 18, 2024

The bump just hurdens the parsing of malicious cors headers. Only browsers make preflight requests. So this does not affect any of our web, desktop or mobile developers. Just Merge.

@dragonchaser
Copy link
Member Author

Closing not relevant to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Topic:Security
Projects
Status: Done
Development

No branches or pull requests

3 participants