Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. sharing issues #9534

Open
ScharfViktor opened this issue Jul 4, 2024 · 1 comment
Open

OCM. sharing issues #9534

ScharfViktor opened this issue Jul 4, 2024 · 1 comment
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jul 4, 2024

precondition:

test 1. users shares folder to federation users after receiver accepted invitation

TEST_SERVER_URL="https://ocis-server:9200" TEST_SERVER_FED_URL="https://federation-ocis-server:10200" BEHAT_FEATURE="tests/acceptance/features/apiOcm/share.feature:12" make test-acceptance-api
Steps:

Given using server "LOCAL"
   And "Alice" has generated invitation
   And using server "REMOTE"
   And "Brian" has accepted invitation
   And using server "LOCAL"
   And user "Alice" has created folder "folderToShare"
   When user "Alice" sends the following resource share invitation using the Graph API:
     | resource        | folderToShare |
     | space           | Personal      |
     | sharee          | Brian         |
     | shareType       | user          |
     | permissionsRole | Viewer        |
   Then the HTTP status code should be "200"
   When using server "REMOTE"
   And user "Brian" lists the shares shared with him using the Graph API
   Then the HTTP status code should be "200"
   And the JSON data of the response should match

Actual: no share for Brian. Alice refresh page-> share disappears

Uploading Screen Recording 2024-01-30 at 12.36.58.mov…

test 2. users shares folder to federation users after accepting invitation

TEST_SERVER_URL="https://ocis-server:9200" TEST_SERVER_FED_URL="https://federation-ocis-server:10200" BEHAT_FEATURE="tests/acceptance/features/apiOcm/share.feature:90" make test-acceptance-api
Steps:

Given using server "LOCAL"
    And "Alice" has generated invitation
    And using server "REMOTE"
    And "Brian" has accepted invitation
    And user "Brian" has created folder "folderToShare"
    When user "Brian" sends the following resource share invitation using the Graph API:
      | resource        | folderToShare |
      | space           | Personal      |
      | sharee          | Alice         |
      | shareType       | user          |
      | permissionsRole | Viewer        |
    Then the HTTP status code should be "200"
    When using server "LOCAL"
    And user "Alice" lists the shares shared with her using the Graph API
    Then the HTTP status code should be "200"
    And the JSON data of the response should match

Actual:
Screenshot 2024-07-04 at 14 01 26

  1. federated share is not accepted by default
  2. no displayName of the user sharer
  3. how is the web supposed to determine that it's a federated resource? there's no type in the response.
  4. no eTag in the response - no clue maybe we don't need to.

CC @butonic @aduffeck

@micbar
Copy link
Contributor

micbar commented Jul 8, 2024

Needs #9554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Qualification
Development

No branches or pull requests

2 participants