Activities. list of the issues

[ScharfViktor]

related owncloud/web#10800
this is mix of the bugs (web and ocis)
I guess some activities are not implemented but I put it to the list for a complete picture

task for implementing tests: #9543

## 1. share resource to many users and groups

Expected:

Actual:

## 2. delete share from many users. looks same as point 1

## 3. upload file into folder

Expected: moss added file to folder f12

Actual:

## 4. no event for downloading file

Expected:

Actual: no events -> backend issue

## 5. no event for downloading file version

Expected: see event
Actual: no events -> backend issue or maybe it was not implemented

## 6. change file content activity looks similar as uploading file

Expected:

Actual: moss added New file.odt to Maurice Moss

## 7. whether the user should be able to see all actions that have occurred before he gets access to resource

Steps: - admin creates folder, adds/changes content, creates share to different users - admin shares folder to einstein with edit permissions

Expected: probably einstein should see the activity from the moment access is gained
Actual: einstein see all activities which were happened before

## 8. no event for restoring file

Expected: admin restores file to Admin
Actual: no event

## 9. no activity for share change (role, expiration date)

Expected: it would be nice to know that share was changed and who did it (in the space context)
Actual: no events

## 10. no activity for public link change (role, expiration date, password)

Expected: it would be nice to know that public link was changed and who did it (in the space context)
Actual: no events

## 11. Activity parent resource refs https://github.com//issues/9536

Expected: admin does something subfolder to parentResource in Space
Actual: admin added subfolder to Space

## 12. Wrong activity log when public changes file content https://github.com//issues/9676

Expected: public does something resource in location
Actual: admin added resource to Admin

## 13. Viewer can see activity of the shared resources: #9849

Expected: no activity for user
Actual:

## 14. Resource id missing in the old activities #9712

Expected: Resource id must be present
Actual: Empty string in place of resource id

## 15. Renaming file with file-id gives move activity instead of rename: #9744

## 16. Activity filter depth:-1 does not list activity: #9850

## 17. Activity lack language translation: #9856

## 18. activity filter limit uncertain behaviour: #9880

[AlexAndBear]

@ScharfViktor All of these are ocis issues, we only transform the text, transferring to ocis repo

[ScharfViktor]

@ScharfViktor All of these are ocis issues, we only transform the text

Yeah, I agree. but maybe point 1 and 2 relate web?

[AlexAndBear]

I don't think so, grouping needs to be implemented in ocis as well

[kulmann]

I'd also like to link #9536 here
@ScharfViktor could you add that to your issue description so that it doesn't get lost in the comments?

[kulmann]

I've set the prio to p3 because it's not used in production anywhere, yet. Still, I think this is quite important to get the product in better shape. I.e. my personal meta-prio is more like a p2.

cc @tbsbdr @micbar

[kobergj]

1. share resource to many users and groups
2. delete share from many users. looks same as point 1

Both not possible at the moment. Adding multiple users to one share is purely a frontend feature. The backend will create one share for each sharee.

3. upload file into folder

Probably misunderstanding. I assumed the spacename to be there. Needs to be clarified.

4. no event for downloading file

Not in scope. Only downloads through links should be logged. Unfortunately we are lacking a way to identify link downloads. However this could be tackled.

5. no event for downloading file version

Not in scope.

6. change file content activity looks similar as uploading file

That is because they are the same. Ocis does not differentiate between new file uploads and new version. Both is a FileUploaded for the backend.

7. whether the user should be able to see all actions that have occurred before he gets access to resource

Works as designed. Activities are only bound to view permission as of now. That means when you get view access to a file you are able to see all its activities even from the past. Needs a precise story when which activities should be shown.

8. no event for restoring file
9. no activity for share change (role, expiration date)
10. no activity for public link change (role, expiration date, password)

All not in scope.

11. Activity parent resource refs Activity parent resource refs #9536

same as ##3 probably just misunderstanding. Needs clarification.

12. Wrong activity log when public changes file content Activities. Wrong activity log when public changes file content #9676

See ##6 besides that this IS a actual bug that was missed during implemenation. We need to identify that this is a public link and do not add the username in this case.

[AlexAndBear]

What does

not in scope

mean? I think those are more feature requests instead of referring to the initial ticket

Both not possible at the moment. Adding multiple users to one share is purely a frontend feature. The backend will create one share for each share.

Grouping might be achieved via creationDate of the share(s)

[kobergj]

I think those are more feature requests instead of referring to the initial ticket

Ah ok. Misunderstood then, sorry. Needs to be decided by PM then.

Grouping might be achieved via creationDate of the share(s)

Might be, yes. But creationDates could be off by milliseconds as they are created one after the other.
Also activitylog system relies on events. Aggregating this events would need an extra step where a consumer reads events, waits for a short time and then maybe aggregates them. This leads to some issues like "How long should it wait?" and "How can it aggregate events?"
I'm not saying this is not possible, but it is not a trivial task. Needs to be decided by PM if aggregating is worth the effort.

[AlexAndBear]

Ah ok. Misunderstood then, sorry. Needs to be decided by PM then.

@tbsbdr awareness ping

'm not saying this is not possible, but it is not a trivial task. Needs to be decided by PM if aggregating is worth the effort.

Fair point, in my simple world, I would just aggregate shares that have been created within a minute (but could give wrong impressions aka wrong data)

[ScharfViktor]

6. change file content activity looks similar as uploading file

That is because they are the same. Ocis does not differentiate between new file uploads and new version. Both is a FileUploaded for the backend.

very sadly that we cannot differentiate actions. Let's imagine we're working with one file in space. And when you want to understand what happened to the file -> you go to the activities and see that many users just added similar file to space. aaa? wait.. I already added this file?? who did what? But what?

not very informative when you want to figure out what happened