Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCIS mono repository #244

Closed
exalate-issue-sync bot opened this issue Oct 6, 2020 · 6 comments
Closed

OCIS mono repository #244

exalate-issue-sync bot opened this issue Oct 6, 2020 · 6 comments
Labels

Comments

@exalate-issue-sync
Copy link

ocis repo should contain core services contained in ocis binary

ocis-files repo should contain files related code, like fileviewer, webdav API, ocs API, ... find this in other epic.

Open questions

  • how to start extensions which are not part of ocis binary
  • how can we integrate REVA better, as a library or by adding services in ocis like storage-registry??
@exalate-issue-sync
Copy link
Author

Alex Unger commented: we have to figure out how to, during the transition from multiple repositories to a single one, update each subtree and preserve the import paths.

As an example, say during the transition, there is a PR on ocis-settings, we want to update the extension settings on owncloud/mono, but changes to the PR import github.com/owncloud/ocis-pkg/v2, while the current mono repository approach import github.com/owncloud/mono/ocis-pkg. Both modules SHOULD contain the exact same code, diferring only on the import path.

@exalate-issue-sync
Copy link
Author

Alex Unger commented: I'm currently addressing the above comment the following way:

  1. update the master branch on your local repository.
  2. run git subtree pull -P accounts/ ../ocis-accounts master on owncloud/mono project root.
  3. resolve merge conflicts (if any) most likely caused by old import paths

@exalate-issue-sync
Copy link
Author

Alex Unger commented: git subtree pull -P accounts/ https://github.com/owncloud/ocis-accounts master can be used without needing to locally clone a repository.

@exalate-issue-sync
Copy link
Author

Michael Barz commented: Linting and Unit tests work fine using the Makefiles in the subfolders.

Unfortunately I have many linting errors.

WIP in https://github.com/owncloud/mono/pull/1

@exalate-issue-sync
Copy link
Author

Michael Barz commented: First CI steps done. Created follow up subtasks.

Parallelization seems to be a good idea.

@exalate-issue-sync
Copy link
Author

Remote key is https://jira.owncloud.com/browse/OCIS-462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant