Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the oC logo on public links causes weird issues #10371

Closed
JammingBen opened this issue Jan 19, 2024 · 1 comment · Fixed by #11137
Closed

Clicking the oC logo on public links causes weird issues #10371

JammingBen opened this issue Jan 19, 2024 · 1 comment · Fixed by #11137
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

Steps to reproduce

  1. Make sure you are running a stack with external apps such as OnlyOffice or Collabora
  2. Create a public link for a folder that includes a docx file
  3. Open the link in an incognito window
  4. Click on the oC logo a few times
  5. Right click the docx file to open the context menu

Expected behavior

Clicking the oC logo always reloads the current link. Right clicking the file shows the context menu and its entries as expected.

Actual behavior

Sometimes the page dies when trying to reload, giving an error Cannot read properties of null (reading 'canCreate'). Reloads that are successful on the other hand cause duplicated entries for external apps in the context menu:

image

The error only exists on master, not on stable-8.0.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jan 19, 2024
@AlexAndBear
Copy link
Contributor

Introduced via #10207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants