Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts with no protocol prefix #11063

Closed
Tracked by #9567
jesmrec opened this issue Jun 19, 2024 · 4 comments
Closed
Tracked by #9567

Shortcuts with no protocol prefix #11063

jesmrec opened this issue Jun 19, 2024 · 4 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@jesmrec
Copy link

jesmrec commented Jun 19, 2024

Describe the bug

Web client creates shortcuts without protocol prefix (if not typed by the user), that leads to unexpected behaviours in other clients that expects the URL inside the shortcuts with http/https. Mobile clients can not open URLs in a browser if the URL has no http/https protocol

Steps to reproduce

  1. New > Shortcut
  2. Add URL without protocol prefix, like owncloud.com
  3. Open shortcut in iOS client

Expected behavior

iOS client opens correctly the shortcut

Actual behavior

iOS can't open because the URL lacks of protocol

Actually, every client behaves in a different way:

  • Web: doesn't add protocol in creation phase
  • iOS: add protocol in creation phase
  • Android: initially, add protocol in creation phase (this is still under QA)

As this unofficial format guide: https://www.lyberty.com/encyc/articles/tech/dot_url_format_-_an_unofficial_guide.html

URL

The URL field is self-explanatory. It’s the address location of the page to load. It should be a fully qualifying URL with the format protocol://server/page. A URL file is not restricted to the HTTP protocol. In general, at least, whatever that can be saved as a favorite is a valid URL.

So, my suggestion is:

  • If user types the protocol in the URL, everything OK ✅
  • If not, adding https:// as default in creation phase

Open to discussion with @felix-schwarz @Aitorbp @JuancaG05 @TheOneRing

@jesmrec jesmrec added the Type:Bug Something isn't working label Jun 19, 2024
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Jun 19, 2024
@kulmann
Copy link
Member

kulmann commented Jun 19, 2024

Fix for this should land in stable-8.0 and master. A patch release of v8.0 makes sense.

@kulmann
Copy link
Member

kulmann commented Jun 19, 2024

I agree with the default behaviour of adding https:// if the user didn't provide a protocol. 👍

@jesmrec
Copy link
Author

jesmrec commented Jun 19, 2024

I agree with the default behaviour of adding https:// if the user didn't provide a protocol. 👍

Thanks for the feedback, we'll do in clients as well (iOS already does, Android will do), so that the URL will be formatted when the shortcut is created.

@JammingBen
Copy link
Collaborator

Has been fixed via #11076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants