Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial page loading spinner never hides in some scenarios #11083

Closed
JammingBen opened this issue Jun 21, 2024 · 2 comments · Fixed by #11084
Closed

Initial page loading spinner never hides in some scenarios #11083

JammingBen opened this issue Jun 21, 2024 · 2 comments · Fixed by #11084
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

Describe the bug

The initial page loading spinner never hides in scenarios where we don't load all apps. This is due to the fact that the spinner only gets removed via a callback after all apps have been loaded.

Steps to reproduce

  1. Go to https://host.docker.internal:9200/access-denied
  2. Enjoy the endless loading state

Expected behavior

The loading spinner eventually disappears.

Actual behavior

It stay forever on such pages.

This is a regression from #11054.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p1-urgent Consider a hotfix release with only that fix labels Jun 21, 2024
@JammingBen JammingBen self-assigned this Jun 21, 2024
@kulmann
Copy link
Member

kulmann commented Jun 24, 2024

I can't reproduce it with current master 🙈 neither mit vite nor with a production build.

@JammingBen
Copy link
Collaborator Author

Now I can't either... but it's a timing issue. The loading spinner appears after 0.5 seconds. Meaning if the page loads faster than that, everything is fine. But if it's slower, then the loading spinner will appear and never go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants