Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing an editor with a dirty state focuses wrong button #11091

Closed
Tracked by #9567
JammingBen opened this issue Jun 24, 2024 · 1 comment
Closed
Tracked by #9567

Closing an editor with a dirty state focuses wrong button #11091

JammingBen opened this issue Jun 24, 2024 · 1 comment
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

JammingBen commented Jun 24, 2024

Describe the bug

Closing an editor with a dirty state (unsaved changes) will show a modal, asking the user if they want to save or leave without saving the document. The modal currently focuses the "Don't save" button initially, which is suboptimal since one single keypress might discard all the changes.

Steps to reproduce

  1. Open a text document with the text editor app
  2. Change something, don't save
  3. Hit the "back"-button in your browser
  4. Hit enter as soon as the modal shows

Expected behavior

The document should be saved and closed.

Actual behavior

The document is not being saved.

Note that we can only fix this for our own modal which shows when e.g. hitting the "back"-button in the browser or when closing the editor via the app bar. Closing the browser tab/window creates a browser popup which we can't control.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Jun 24, 2024
@JammingBen JammingBen self-assigned this Jun 25, 2024
@kulmann
Copy link
Member

kulmann commented Jun 28, 2024

Closed via #11094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants