Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.1.4.4 - Text scalable to 200 % #5385

Closed
3 of 4 tasks
tbsbdr opened this issue Jun 25, 2021 · 5 comments
Closed
3 of 4 tasks

[a11y] 9.1.4.4 - Text scalable to 200 % #5385

tbsbdr opened this issue Jun 25, 2021 · 5 comments

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 25, 2021


General notes

Note: This was tested with a browser window size of 1280 x 768 pixels and a zoom of 200%.

Status: rather not fulfilled

  • Page 1 (Alle Dateien)
    When copying or moving elements, the left menu disappears and doesn’t show up anymore like the hamburger button on the other sides.

Status: fulfilled

  • Page 2 (Mit anderen geteilten Dateien)
  • Page 3 (Gelöschte Dateien)
  • Page 4 (Konto)
@pascalwengerter
Copy link
Contributor

@tbsbdr @kulmann this one needs a bit more radical changes I'm afraid. What was the reasoning of not having any nav (top nav & left sidebar) present when copying/moving resources?

@kulmann
Copy link
Member

kulmann commented Aug 3, 2021

I don't know the reasoning. @LukasHirt maybe?

@kulmann
Copy link
Member

kulmann commented Aug 3, 2021

IMO would be ok to include the topbar there as well.

@stevefrenzel
Copy link

@kulmann @pascalwengerter @tbsbdr

I'm not sure why a high zoom level is causing the header element with id oc-topbar to disappear. My guess is a function involving the window with, like this one:

isSidebarVisible() {
      if (this.sidebarNavItems.length === 0) {
        return false
      }
      return this.windowWidth >= 1200 || this.appNavigationVisible
    }

I fiddled around with anything that could be related to it but didn't have any success. I think someone with more experience with this architecture should have a look and and find the parameter that's causing this weird behaviour?

@pascalwengerter
Copy link
Contributor

Superseded by the more recent #10727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants