Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting ResourceTable causes lazy loading sceleton to never disappear #6434

Closed
lookacat opened this issue Feb 14, 2022 · 5 comments
Closed
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@lookacat
Copy link
Contributor

Steps to reproduce

Click sorting at least 3-4 times.

Expected behaviour

Lazy loading sceleton should not appear

Actual behaviour

Lazy loading sceleton appears and never goes away

Screenshot

sceleton_bug

@lookacat lookacat changed the title Sorting ResourceTable many times causes lazy loading sceleton to never disappear Sorting ResourceTable causes lazy loading sceleton to never disappear Feb 14, 2022
@fschade fschade added Type:Bug Something isn't working Topic:good-first-issue beginner friendly task labels Mar 4, 2022
@JammingBen
Copy link
Collaborator

@lookacat Could you please check if that's still a thing for you? I suppose that the recent performance updates have solved this issue.

@JammingBen
Copy link
Collaborator

I had the same issue several times now. It seems to happen when you change the sort order of resources, navigate to another page, and then navigate back to your personal space.

I think it has something to do with reading values from the local storage. Because as soon as you prune it, things are fine again. Also, it only occours when Web is running via pnpm vite (for me).

@JammingBen JammingBen removed the Topic:good-first-issue beginner friendly task label Mar 22, 2023
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label May 4, 2023
@kulmann
Copy link
Member

kulmann commented May 4, 2023

Can confirm. Happens if you navigate e.g. to Shared with me, try to sort (which is broken entirely), then navigate back to Personal.

Looking at the localStorage (browser dev tools -> Application -> Local Storage) there are view-specific sort key-value pairs. Deleting the view-specific sorting options from localStorage "solves" the issue...

Screenshot 2023-05-04 at 12 54 15

Screenshot 2023-05-04 at 12 54 34

@kulmann
Copy link
Member

kulmann commented May 4, 2023

See #8981 for the broken sorting on the shared with me page, that I mentioned in my previous comment.

@JammingBen
Copy link
Collaborator

Fixed via #8988.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants