Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error In version 80100.47 #35

Open
Ghli opened this issue Feb 14, 2019 · 6 comments
Open

Error In version 80100.47 #35

Ghli opened this issue Feb 14, 2019 · 6 comments
Assignees

Comments

@Ghli
Copy link

Ghli commented Feb 14, 2019

The error that was fixed in v46 apparently still hasn't fixed errors. I'm currently getting the following

1x BonusRollPreview\BonusRollPreview-80100.47-Release.lua:128: Bad Instance ID.  Usage: EJ_SelectInstance(ID)
[C]: in function `EJ_SelectInstance'
BonusRollPreview\BonusRollPreview-80100.47-Release.lua:128: in function `StartEncounter'
BonusRollPreview\BonusRollPreview-80100.47-Release.lua:98: in function <BonusRollPreview\BonusRollPreview.lua:54>

Locals:
InCombatSkipped
@p3lim p3lim self-assigned this Feb 18, 2019
@p3lim
Copy link
Member

p3lim commented Feb 18, 2019

Which dungeon did this happen in, and which encounter?

@Ghli
Copy link
Author

Ghli commented Feb 18, 2019

This happened during BoD normal Alliance side, but i did not catch when this error popped up until midway through normal. I only mention "Alliance side" due to SavedInstances/SavedInstances#233 might be indirectly related due to the difference in order of how bosses are killed in Alliance vs Horde.

@Cluuey
Copy link

Cluuey commented Feb 18, 2019

I was about to report this too.
I got the same error, it popped up on Grong for me but I also noticed there was no little arrow on Jadefire Masters.
You still get the icon to change loot spec but no summary of loot options, for the other bosses it works. I noticed it worked on Opulence, I don't recall it not working on the first fight.

So I think it's a problem caused by the Grong and Jadefire bosses being in a different order depending on which faction you are. I'll try and pay attention to this on the normal clear next reset, I only noticed it on heroic this week.
This is what the Adventure Guide showed after the error, it still opened after clicking the normal shortcut area.
image

@SJPadbury
Copy link

SJPadbury commented Feb 21, 2019

Message: ...terface\AddOns\BonusRollPreview\BonusRollPreview-80100.47-Release.lua:128: Bad Instance ID.  Usage: EJ_SelectInstance(ID)
Time: Wed Feb 20 21:27:11 2019
Count: 1
Stack: ...terface\AddOns\BonusRollPreview\BonusRollPreview-80100.47-Release.lua:128: Bad Instance ID.  Usage: EJ_SelectInstance(ID)
...terface\AddOns\BonusRollPreview\BonusRollPreview.lua:98: in function <...terface\AddOns\BonusRollPreview\BonusRollPreview.lua:54>

Locals: self = BonusRollPreview {
 0 = <userdata>
 UpdateItemFilter = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:215
 DisableScrolling = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:305
 Toggle = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:312
 EnableScrolling = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:291
 ToggleLock = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:286
 ScrollFrame = <unnamed> {
 }
 UpdateHandlePosition = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:244
 StartEncounter = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:125
 OnLoad = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:37
 RegisterSafeEvent = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:225
 OnEvent = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:54
 instanceID = 0
 UpdatePosition = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:275
 UpdateItems = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:133
 encounterID = 2326
 difficultyID = 14
 UnregisterSafeEvent = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:235
 buttons = <table> {
 }
}
event = "SPELL_CONFIRMATION_PROMPT"
spellID = 259072
confirmType = 1
_ = ""
_ = 180
currencyID = 1580
currencyCost = 1
difficultyID = 14
instanceID = 0
encounterID = 2326
tSize = <function> defined @Interface\AddOns\BonusRollPreview\BonusRollPreview.lua:26
query = <table> {
}
LE_SPELL_CONFIRMATION_PROMPT_TYPE_BONUS_ROLL = 1
ignoredSpells = <table> {
 240052 = true
 240042 = true
 232109 = true
 240048 = true
}
EJ = <table> {
 GetJournalInfoForSpellConfirmation = <function> defined @Interface\AddOns\BonusRollPreview\libs\EJ_Ext\EJ_Ext.lua:183
}

@Ghli
Copy link
Author

Ghli commented Feb 22, 2019

I can report back that this bug popped up on Alliance after heroic jadefire masters and heroic grong

@Cluuey
Copy link

Cluuey commented Mar 7, 2019

I've got no idea what's happening now.
Some weeks I don't get an error and other weeks I do, unfortunately once a week is not a good way of trying to track problems down.

I will note that I've heard a few people say things similar to, "why is the loot journal empty for Grong?"
As far as I know they aren't using this addon so perhaps it's a bug on Blizzards end.

Next time I hear this said I'll ask them what addons they're using which do loot related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants