Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making secondary directory optional #12

Open
alrosot opened this issue Mar 5, 2018 · 3 comments
Open

Making secondary directory optional #12

alrosot opened this issue Mar 5, 2018 · 3 comments

Comments

@alrosot
Copy link

alrosot commented Mar 5, 2018

This is not an issue. Please treat this as a question or maybe a feature request.

Expected behaviour

I find it would be useful to only have one directory passed as argument (primary directory). So the app would find duplicates on that mix (and then we would need to decide somehow which coppy is to keep)

Actual behaviour

The current app requires a secondary directory, as per these lines:

if (!fs.existsSync(secondaryDir)) { console.error(Secondary directory (${secondaryDir}) does not exist); process.exit(1); }

Versions and environment

  • image-duplicate-remover: 0.2.0 (being developed)

Thank you and have some 🍻.

@paazmaya
Copy link
Owner

paazmaya commented Mar 5, 2018

How about giving the same value for both primary and secondary directories?

@alrosot
Copy link
Author

alrosot commented Mar 5, 2018

I'm struggling to test this locally, but wouldn't it make everything a duplicate?

@paazmaya
Copy link
Owner

paazmaya commented Mar 6, 2018

@alrosot You are correct. So another mechanism would be needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants