-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon support? #42
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump on this. I’ll go ahead and open a PR too :) |
This would be amazing! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It would be nice if the Primer theme could add support for favicons. Spefically, it would be nice if
default.html
could add a<link rel="icon">
tag to the page if afavicon
option is specified in_config.yml
.I first considered whether the Favicon should be included as part of the Jekyll SEO tag. However, I don't think the plugin should offer support for favicons, especially given its focus on generating machine-readable metadata for search engines and social networks.
I'm happy to open a PR to add favicon support — it should be extremely straightforward — but I wanted to ask for opinions before I do so. Comments and suggestions would be appreciated 😃
The text was updated successfully, but these errors were encountered: