Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write more node e2e tests #6626

Closed
mattsse opened this issue Feb 16, 2024 · 2 comments · Fixed by #6972
Closed

Write more node e2e tests #6626

mattsse opened this issue Feb 16, 2024 · 2 comments · Fixed by #6972
Assignees
@loocapro
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 16, 2024 •
edited
Loading

Describe the feature

with #6611 with now have a convenient way to launch a test node.

No we can write proper e2e tests for this we can start with a new testing crate node-tests
In there we want various test setups:

  • launch node, use engine API to advance the chain, reorgs etc..
  • query new state via RPC, blocks, transactions, tracing
  • query state via network, by launching a separate peer and connecting to the node, see TestNet in reth-network
  • etc...

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test labels Feb 16, 2024
@loocapro
Copy link
Contributor

I can take this

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 16, 2024

will ping once merged

@loocapro loocapro mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loocapro loocapro

Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node tests crate loocapro/reth
2 participants
@loocapro @mattsse