Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate usage of proptest_arbitrary & arbitrary and consider deduplicating #8209

Closed
gakonst opened this issue May 12, 2024 · 1 comment · Fixed by #8968
Closed

Investigate usage of proptest_arbitrary & arbitrary and consider deduplicating #8209

gakonst opened this issue May 12, 2024 · 1 comment · Fixed by #8968
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@gakonst
Copy link
Member

gakonst commented May 12, 2024

Describe the feature

What should we do about proptest_arbitrary & arbitrary? Should we just have one? I forget why we have both.

We use both across the codebase and we could benefit from deduplicating. This currently leaks also into alloy

Additional context

No response
@gakonst gakonst added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 12, 2024
@onbjerg onbjerg mentioned this issue May 12, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 3, 2024
@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain and removed S-stale This issue/PR is stale and will close with no further activity C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 3, 2024
@Rjected Rjected added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity D-good-first-issue Nice and easy! A great choice to get started labels Jun 12, 2024
@Rjected Rjected mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove proptest arbitrary from codec derive and tests paradigmxyz/reth
3 participants
@Rjected @onbjerg @gakonst