Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic reth stage cli command flow testing #8975

Closed
3 tasks
Rjected opened this issue Jun 19, 2024 · 5 comments · Fixed by #10127 or #10164
Closed
3 tasks

Basic reth stage cli command flow testing #8975

Rjected opened this issue Jun 19, 2024 · 5 comments · Fixed by #10127 or #10164
Assignees
@greged93
Labels
A-ci Related to github workflows or other build and lint tools C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@Rjected
Copy link
Member

Rjected commented Jun 19, 2024

Right now we do not have any integration testing for most of the commands that we include, such as stage unwind, stage run, etc. We can check that these commands work at the very least, by running them in CI.

We would want to test at least the following commands:

Tasks
Beta Give feedback

See #8974 for the first kind of example of this
@Rjected Rjected added D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test A-ci Related to github workflows or other build and lint tools labels Jun 19, 2024
@greged93
Copy link
Contributor

hey @Rjected, I'm down to work on this

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 20, 2024
@Rjected Rjected added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 22, 2024
@Rjected
Copy link
Member Author

Rjected commented Aug 2, 2024

hey @greged93 would you still like to work on this?

@greged93
Copy link
Contributor

greged93 commented Aug 2, 2024

Hey @Rjected, yes, I would be able to start on Monday if that works, if the work is urgent then no worries

@Rjected
Copy link
Member Author

Rjected commented Aug 2, 2024

Hey @Rjected, yes, I would be able to start on Monday if that works, if the work is urgent then no worries

that sounds good! just assigned

@greged93 greged93 mentioned this issue Aug 6, 2024
Merged
@greged93 greged93 mentioned this issue Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greged93 greged93

Labels
A-ci Related to github workflows or other build and lint tools C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add header to stage command greged93/reth
feat: add stage run <STAGE> tests greged93/reth
2 participants
@Rjected @greged93