Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release CI: Bulletproof SemVer Checks #4817

Open
ggwpez opened this issue Jun 18, 2024 · 0 comments
Open

Release CI: Bulletproof SemVer Checks #4817

ggwpez opened this issue Jun 18, 2024 · 0 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Jun 18, 2024

The current CI checks are structured in a way that the R0-silent label skips the SemVer checks. This is good in general, but i already saw two merge requests that declared R0 and had accidental breaking changes.

I think we should do something like this:

graph TD
    A(Merge Request) --> B{SemVer Change Detected?}
    B -- No --> Advise{Targets Stable?}
    Advise -- No --> Ok
    Advise -- Yes --> Comm[Comment Generic backport advise]
    B -- Yes --> R1{Has R0 label?}
    R1 -- No --> S{Targets Stable?}
    S -- No --> Ok2[Check PrDocs]
    S -- Yes --> nM[Ensure PrDocs are minor]
    R1 -- Yes --> Major{Is Major change?}
    Major -- No --> W[Warn about removing R0]
    Major -- Yes --> Stable{Targets Stable?}
    Stable -- No --> W
    Stable -- Yes --> E[Error: Forbidden]
Loading
@EgorPopelyaev EgorPopelyaev pinned this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant