Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of libp2p dependency in sc-network-sync #4858

Open
dmitry-markin opened this issue Jun 21, 2024 · 2 comments
Open

Get rid of libp2p dependency in sc-network-sync #4858

dmitry-markin opened this issue Jun 21, 2024 · 2 comments
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I4-refactor Code needs refactoring. T0-node This PR/Issue is related to the topic “node”.

Comments

@dmitry-markin
Copy link
Contributor

libp2p is currently pulled in as a dependency of sc-network-sync due to the use of libp2p::request_response::OutboundFailure in substrate/client/network/sync/src/engine.rs. This should be refactored/replaced by a network backend agnostic type.

@dmitry-markin dmitry-markin added I4-refactor Code needs refactoring. T0-node This PR/Issue is related to the topic “node”. labels Jun 21, 2024
@bkchr bkchr added the C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. label Jun 23, 2024
@cenwadike
Copy link

First time attempting to contribute to polkadot SDK, I'd like to give this a shot

@cenwadike
Copy link

Hello @dmitry-markin, I'd like to know what defines an agnostic type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I4-refactor Code needs refactoring. T0-node This PR/Issue is related to the topic “node”.
Projects
Status: No status
Development

No branches or pull requests

3 participants