Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError on initial playback after upgrading to 6.4.0 #1024

Open
mssever opened this issue Jun 18, 2024 · 1 comment
Open

TypeError on initial playback after upgrading to 6.4.0 #1024

mssever opened this issue Jun 18, 2024 · 1 comment

Comments

@mssever
Copy link
Contributor

mssever commented Jun 18, 2024

After upgrading from version 6.3.0 to 6.4.0 (by changing the version in package.json, deleting node_modules/, and reinstalling), I'm having an issue with playback.

When I click the play button I get an exception. Here's the traceback:

create-synth.js:318 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'swing')
    at create-synth.js:318:21
    at new Promise (<anonymous>)
    at CreateSynth.self.prime (create-synth.js:302:10)
    at ScorePlayback.init (ScorePlayback.ts:65:23)

In case it isn't clear from the traceback, I have my own init method. Here's the relevant portion:

const midi_buffer = new ABCJS.synth.CreateSynth();
await midi_buffer.init({
  visualObj: this.rendered_score[0],
  // debugCallback: console.debug,
});
await this.controller.setTune(this.rendered_score[0], false);
await midi_buffer.prime();

In midi_buffer#prime, self.options is undefined, precipitating the exception.

If I click the play button a second time, no exception is raised and playback proceeds as normal except that timing callbacks aren't called. But that might be due to an unrelated issue.

Downgrading to 6.3.0 resolves the issue.

@paulrosen
Copy link
Owner

Sorry! I quickly fixed it: upgrade to 6.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants