-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overly sensitive to minor color variations #9
Comments
@gnachman Do you have a copy of this version somewhere? It's not a big deal to make these changes myself but if you made them available it might save me half an hour. Thanks! |
In In |
Thanks, @gnachman! |
Check out my fork for an implementation (specifically frarees@0bb2818). |
macOS dithers solid colors in recent OS versions. This is noticeable on 10.15 with a macbook pro in direct sunlight, for example. Furthermore, antialiasing artifacts due to unaligned drawing on a retina display can cause fuzzy edges. Because typometer checks only for exact color equivalence, it often gets tripped up.
I was unable to use it at all on macOS until I made the following changes:
BenchmarkImpl.typeSync
to consider colors differing by less than 1% to be equal (by summing the difference of the red, green, and blue channels)MetricsDetector.uniformLengthFrom
to ignore the 2 least significant bits of each color channel.The text was updated successfully, but these errors were encountered: