Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests #8

Open
pentzzsolt opened this issue Jul 18, 2018 · 5 comments
Open

Create tests #8

pentzzsolt opened this issue Jul 18, 2018 · 5 comments
Assignees
Milestone

Comments

@pentzzsolt
Copy link
Owner

No description provided.

@pentzzsolt pentzzsolt added this to the v1.1.0 milestone Jul 18, 2018
@pentzzsolt pentzzsolt self-assigned this Jul 18, 2018
@howardcox
Copy link

@pentzzsolt did you have a particular testing method in mind? oddbird/true ?

@pentzzsolt
Copy link
Owner Author

I actually started implementing test cases using Hugo Giraudel's Sassy Tester function. My problem is that I haven't had the time to actually figure out what I want this to do, so I just left it unfinished for now. Hopefully in this new year I'll have the time to spend on this.

@howardcox
Copy link

Oh ok, because I wrote some tests for the generic case, as well as for my merging lists feature, using oddbird/true.

But if you'd prefer SassyTester I could port my test cases over to that and make a PR them? The unit tests helped me reveal some odd behaviour with my initial implementation of merging-lists (lists in SASS are weird) so I've also patched the 'join-lists' behaviour in my fork too.

@howardcox
Copy link

Actually it looks like HugoGiraudel/SassyTester is unmaintained, so oddbird/true might be the better bet anyway.

You can have a look at the tests I wrote here if you want to check prior to a PR:

https://github.com/howardcox/sass-recursive-map-merge/blob/recursive-join-lists-%234/test/test.scss

@pentzzsolt
Copy link
Owner Author

That's a lot of work! 😲
Thanks a lot for doing that! As you can see, lately, I haven't had much time to spend on this project, or any other for that matter, but the smoke should clear up in the following weeks and I will get back to this project and give it the attention that it needs.
I went with SassyTester even though I knew it was unmaintained, simply because it did exactly what I thought I needed. Looking at your tests, they do seem more sophisticated and also, the fact that the project is maintained is never bad. 🙂
I will come back to this conversation in the following weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants