Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSc and SSrc commands are outdated #2

Open
claudiocabral opened this issue Aug 27, 2019 · 6 comments
Open

CSSc and SSrc commands are outdated #2

claudiocabral opened this issue Aug 27, 2019 · 6 comments

Comments

@claudiocabral
Copy link

In the latest firware, Border related controls were removed from CSSc and SSrc commands.
Instead, we have the new CSBd and SSBd commands. I still haven't cheked their structure, so I don't know if it's just a copy paste of the removed sections or if there's anything new. If you're still maintaining this package, I'd love to submit a pull request as soon as I have something to share

@Julusian
Copy link
Contributor

You are correct, and dont forget that a ssrc id field has been added near the beginning of the commands too.
I can confirm it is a cut and paste of structure, you an see the different versions in javascript form here: https://github.com/nrkno/tv-automation-atem-connection/blob/develop/src/commands/SuperSource/SuperSourcePropertiesCommand.ts

@peschuster
Copy link
Owner

It would be great if you could create a pull request.
I haven't used v8 yet and only occasionally have access to a unit with 2 M/Es and SuperSource, but maybe you could include a pcap file with an example.

@claudiocabral
Copy link
Author

I'll check with my boss what the priorities are, but in any case I'll some free time next week that I can use on it. How would you like me to include the pcap example file?

I'm testing out the protocol looking for any changes, please let me know in you guys are aware of anything else

@peschuster
Copy link
Owner

You could just add it to the examples directory. I just recently created it and uploaded a capture file I had lying around.

@claudiocabral
Copy link
Author

So, after a month I've finally been reassigned to work with this.
I saw that you generated the fields, could you explain what process you normally use to add changes?

@peschuster
Copy link
Owner

I did the initial version by generating the code with some scripts from the HTML "spec", but all the latest additions were done manually. Just edit the lua source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants