Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running thanks without argument could simply scan a pip freeze #11

Open
ramnes opened this issue Feb 19, 2018 · 1 comment
Open

Running thanks without argument could simply scan a pip freeze #11

ramnes opened this issue Feb 19, 2018 · 1 comment
Projects

Comments

@ramnes
Copy link

ramnes commented Feb 19, 2018

Because packages often come with dependencies that are not always written in requirements files, I'd love to be able to run thanks anywhere without argument, and having it to get the packages to scan from a simple pip freeze.

Such a feature would be particularly interesting in virtualenv settings, and make thanks work in a similar fashion than feross/thanks.

PS: thank you for writing this piece of code! I definitely wanted to do it too when I saw the JS version 10 days ago, and it was actually a top priority in my spare time to-do list… but it looks like I was too slow. 😄

@phildini
Copy link
Owner

Hey! Thanks for the suggestion. I 100% agree that this functionality would be great, and it's mostly there already. If you're interested in taking this on, pip.get_installed_distributions() will be your friend. Check out what's going on at:

https://github.com/phildini/thanks/blob/master/thanks/thanks.py#L29

@phildini phildini added this to To do in Thanks May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Thanks
  
To do
Development

No branches or pull requests

2 participants