Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : How about showing links to github project - twitter profile of the author? #6

Open
waseem18 opened this issue Feb 11, 2018 · 6 comments
Projects

Comments

@waseem18
Copy link

waseem18 commented Feb 11, 2018

If the user wants to donate he would hit the command thanks requirements.txt donate which would show links to the authors patreon pages. While thanks requirements tweet would show the authors twitter profile links using which user can tweet the author expressing his love for the library.

The same for github as well - it would show github project links which helps people star the project.

I was planning to put this up in the package that I'm building but thought of chiming in my thoughts here instead of building yet another thanks library 😄

@phildini
Copy link
Owner

Hey! I think something like thanks tweet requirements.txt is pretty reasonable, but I'm still thinking about it.

I definitely worry about too much information or information overload, so if you have thoughts on what the output would look like that would be amazing to see.

@waseem18
Copy link
Author

By output if you meant to say cli UI - I don't have it.

I mean to say it would similar to the output of the command thanks requirements.txt as of now.

@diego-vicente
Copy link

I was indeed writing a small script to automatically star dependencies of a project in GitHub (heavily inspired by cargo-thanks). Right now, I have small pieces of code for fetching github repositories of the dependencies, which should be enough right now to fit in the current script (just listing the repositories and let the user manually star the ones he is interested in).

I think it could be nice to include the functionality using a simple --github flag to the script to show the links to the repositories instead the donations: not overloading the input, and offered as an alternative of "real" support (as donations are). @phildini, if this sounds good to you I can start working on a PR!

@phildini
Copy link
Owner

phildini commented Feb 13, 2018

Hey @DiegoVicen! Yes, I will happily look at a PR. There are some changes incoming that might mean the PR goes through a couple rounds, but I'd still love to have some code-thoughts on what this looks like. 😄

@phildini
Copy link
Owner

Hey @DiegoVicen you might want to keep an eye on #7. I'm thinking of trying to pull project funding info from the setup.py, and pulling the github info from there as well seems ideal.

@diego-vicente
Copy link

The prototype I mentioned just parses the output of pip show <package> and hopes to find a github link (which is not the case in many big packages, like numpy for instance), so that actually sounds promising. If not, at least using both methods and try to complement each other.

@phildini phildini added this to To do in Thanks May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Thanks
  
To do
Development

No branches or pull requests

3 participants