Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count memory cost for returned []byte or SliceLocation #50131

Closed
lance6716 opened this issue Jan 5, 2024 · 1 comment · Fixed by #50130
Closed

count memory cost for returned []byte or SliceLocation #50131

lance6716 opened this issue Jan 5, 2024 · 1 comment · Fixed by #50130
Labels
affects-7.6 priority/release-blocker This PR blocks a release. Please review it ASAP. severity/major type/bug This issue is a bug. type/enhancement

Comments

@lance6716
Copy link
Contributor

lance6716 commented Jan 5, 2024 •
edited

Enhancement

We have limited the total memory block acquired from membuf.Pool to 16G, but the keys and values type which has their underlying array pointing to membuf.Pool also costs a lot memory so the node may OOM.

image
⬇️
image
@lance6716 lance6716 mentioned this issue Jan 5, 2024
Merged
13 tasks
@tangenta
Copy link
Contributor

Adding index with global sort encounter OOM. We need to merge the fix to release-7.6. Let me change this issue to bug.

ti-chi-bot bot pushed a commit that referenced this issue Jan 17, 2024
@lance6716
membuf: count memory cost for returned []byte or SliceLocation (#50130)
2e6c0ae 
close #50131
@ti-chi-bot ti-chi-bot mentioned this issue Jan 17, 2024
Merged
13 tasks
@lance6716 lance6716 added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Jan 17, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 17, 2024
@ti-chi-bot
membuf: count memory cost for returned []byte or SliceLocation (#50130)…
22f1ebd 
… (#50516)

close #50131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.6 priority/release-blocker This PR blocks a release. Please review it ASAP. severity/major type/bug This issue is a bug. type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

membuf: count memory cost for returned []byte or SliceLocation lance6716/tidb
2 participants
@lance6716 @tangenta