Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/security: support client TLS verifies CommonName of server #53358

Merged
merged 1 commit into from
May 20, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53357

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
Copy link

tiprow bot commented May 17, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716 lance6716 requested a review from dveeden May 17, 2024 07:41
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7746%. Comparing base (9c89227) to head (7d131a2).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53358        +/-   ##
================================================
+ Coverage   72.5225%   74.7746%   +2.2520%     
================================================
  Files          1505       1505                
  Lines        429836     430808       +972     
================================================
+ Hits         311728     322135     +10407     
+ Misses        98803      88819      -9984     
- Partials      19305      19854       +549     
Flag Coverage Δ
integration 49.3042% <0.0000%> (?)
unit 71.5221% <100.0000%> (+0.0973%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4844% <ø> (+9.0872%) ⬆️

@hawkingrei
Copy link
Member

/ok-to-test

@lance6716
Copy link
Contributor Author

/retest

@lance6716 lance6716 changed the title util/security: support client TLS verify CN of server util/security: support client TLS verifies CN of server May 17, 2024
@lance6716 lance6716 changed the title util/security: support client TLS verifies CN of server util/security: support client TLS verifies CommonName of server May 20, 2024
Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [D3Hunter,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-17 07:53:10.964110339 +0000 UTC m=+1812544.721245913: ☑️ agreed by hawkingrei.
  • 2024-05-20 02:31:03.677947285 +0000 UTC m=+2052417.435082868: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 397a460 into pingcap:master May 20, 2024
23 checks passed
@3AceShowHand
Copy link
Contributor

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.5: #53464.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client TLS should not set InsecureSkipVerify if need to verify Common Name
5 participants