Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP management with engine #76

Open
mingu600 opened this issue Aug 12, 2021 · 2 comments
Open

PP management with engine #76

mingu600 opened this issue Aug 12, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mingu600
Copy link
Contributor

Hello! I have been using your showdown engine and it's really cool. I just had a quick question- is PP management implemented? It looks like PP management isn't an "instruction" from giving a move, and also "Side" methods like get_self_options don't check if a move is out of PP, but rather if a move is disabled. Do I need to manually reduce a move's PP count by changing it in mutator.state, and then disable the move if the PP is 0, or is that functionality already there somewhere with the engine? Thanks!

@pmariglia
Copy link
Owner

PP management is not implemented. The instructions generated from using a move do not include any kind of decrement_pp instruction. Doing so is possible, but it would provide little benefit for a bot that can only see 2 turns ahead.

If the bot is out of PP then the PokemonShowdown server will tell it that it's move is disabled, so there's no worry about getting stuck because it is trying to use a move that is out of PP.

@pmariglia pmariglia added the bug Something isn't working label Aug 15, 2021
@pmariglia
Copy link
Owner

Also related to this:

The PokemonShowdown server does not send specific move information for your reserve Pokemon. This means that if the bot has a reserve Pokemon with a move that is out of PP then it will think that it can switch-in and use that move, when in reality it cannot. This can probably have some performance implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants