Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional error identified in file mandels_problem.ipynb #1137

Open
OmarDuran opened this issue Mar 7, 2024 · 6 comments
Open

Functional error identified in file mandels_problem.ipynb #1137

OmarDuran opened this issue Mar 7, 2024 · 6 comments
Assignees
Labels
bug Something is not working as expected.

Comments

@OmarDuran
Copy link
Contributor

Attempts to employ catersian grids in the tutorial notebook produce incorrect approximations for the Mandel's problem. Possible source of the error is the combination of mpsa, cartesian grids and some kind of BC. The following MWE derived from the tutorial is exhibiting such functional error.
mwe_mandels_problem.py.zip

@OmarDuran OmarDuran added the bug Something is not working as expected. label Mar 7, 2024
@IvarStefansson IvarStefansson self-assigned this Mar 14, 2024
@IvarStefansson
Copy link
Contributor

Can this be closed, @OmarDuran? I believe the explanation is inherent to the discretization method, right, @keileg?

@keileg
Copy link
Contributor

keileg commented May 22, 2024

Yes, there's no getting around this. The only question is if we should leave an explicit warning in the tutorial not to use such a combination of methods (I'm not sure if there is such a comment now). I'm not sure I am in favor of such a change.

@IvarStefansson
Copy link
Contributor

Could you please take action as you see fit and then close the issue?

@OmarDuran
Copy link
Contributor Author

My understanding of the advantages of a multipoint finite volume method is twofold: lowest order approximations and general meshes, including cartesian meshes. @IvarStefansson I am unable to understand how the explanation is inherent in the discretization method. Fixing this issue, however, is quite involved, and I would rather not take any action in this regard rather than leave this issue open for the record of users.

@IvarStefansson
Copy link
Contributor

Sorry about the misunderstanding. My suggestion was for @keileg to add the warning if required.

@keileg keileg assigned keileg and unassigned IvarStefansson May 24, 2024
@keileg
Copy link
Contributor

keileg commented May 24, 2024

Sorry about the misunderstanding. My suggestion was for @keileg to add the warning if required.

I'll take care of it, though it may take a week or so to find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected.
Projects
None yet
Development

No branches or pull requests

3 participants