Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the method _parse_other in the Ad operator class #1180

Open
keileg opened this issue Jun 7, 2024 · 0 comments
Open

Delete the method _parse_other in the Ad operator class #1180

keileg opened this issue Jun 7, 2024 · 0 comments
Labels
user group Issue to be worked on in the internal user group.

Comments

@keileg
Copy link
Contributor

keileg commented Jun 7, 2024

The method pp.ad.Operator._parse_other() is almost surely never used in practice; rather it is a remnant of an older approach to the parsing. We should verify that it is actually not used, and purge if possible. This should not be a major task.

This will be a preparatory step towards a full rework of the Ad operator parsing. Though the purge can be done together with a larger rewrite, it is preferable to do it before, so that the code is a bit cleaner when we move to the larger part.

@keileg keileg changed the title #18 Purge method Operator._parse_other. Should not be needed Delete the method _parse_other in the Ad operator class Jun 7, 2024
@keileg keileg added the user group Issue to be worked on in the internal user group. label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user group Issue to be worked on in the internal user group.
Projects
None yet
Development

No branches or pull requests

1 participant