Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github workflow] Check PR image build to run from forks #475

Open
igoychev opened this issue Mar 21, 2023 · 1 comment
Open

[github workflow] Check PR image build to run from forks #475

igoychev opened this issue Mar 21, 2023 · 1 comment
Assignees
@imilchev
Labels
type: bug Something isn't working

Comments

@igoychev
Copy link
Contributor

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)

Testing

Describe the Bug

Currently the PR docker image build tests are run from master, but should run from the PR instead when the branch is in a fork.

To Reproduce

See the failed tests here: #474

Expected Behavior

The image build to test the code from the PR

Which browser are you using? (if relevant)

No response
@igoychev igoychev added the type: bug Something isn't working label Mar 21, 2023
@igoychev
Copy link
Contributor Author

just found the solution, while fixing the same problem in the frontend repo:
The fix of the Docker checkout action is to add "context: ." as per the path context docs after this line here:

api/.github/workflows/security-checks.yml

Line 21 in 6d1bd9f

with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imilchev imilchev

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igoychev @imilchev