Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using system_accountNextIndex #10641

Open
bkchr opened this issue Jun 4, 2024 · 3 comments
Open

Stop using system_accountNextIndex #10641

bkchr opened this issue Jun 4, 2024 · 3 comments

Comments

@bkchr
Copy link

bkchr commented Jun 4, 2024

Pjs should stop using the Rpc and instead switch to the runtime api. The rpc requires that the node is aware of the accountid, which contradicts the "omni node future".

This has one downside, the rpc is adjusting the nonce based on the content in the local transaction pool. However, this will also not really work for light clients as they only keep their own transactions and not external transactions. Users are expected to not use their account from different devices/apps at once.

@bkchr
Copy link
Author

bkchr commented Jun 24, 2024

@TarikGul do you know if there is any way to skip this RPC right now?

@TarikGul
Copy link
Member

If Im not mistaken this needs to be adjusted in the api layer. I am doing a release of the api tomorrow - It's a must need urgent release. I will try and get this adjusted as well!

If I am not mistaken all that needs to be changed is the rpc call needs to be replaced with the runtime api call?

@TarikGul
Copy link
Member

To further clarify why this is an api level issue: api.derive.tx.signingInfo is where the rpc call is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Issues (Upstream)
Development

No branches or pull requests

2 participants