fix(migration): crash if certain role types didn't exist

polonel · Feb 24, 2019 · 39dfaa2 · 39dfaa2
1 parent 05eb49f
commit 39dfaa2
Showing 1 changed file with 18 additions and 9 deletions.
diff --git a/src/migration/index.js b/src/migration/index.js
@@ -80,9 +80,12 @@ function migrateUserRoles (callback) {
         userSchema.collection.updateMany({ role: 'admin' }, { $set: { role: adminRole._id } }).then(function (res) {
           if (res && res.result) {
             if (res.result.ok === 1) return next(null, roles)
-
-            winston.warn(res.message)
-            return next(res.message)
+            else {
+              winston.warn(res.message)
+              return next(res.message)
+            }
+          } else {
+            return next('Unknown Error Occurred')
           }
         })
       },
@@ -93,9 +96,12 @@ function migrateUserRoles (callback) {
           .then(function (res) {
             if (res && res.result) {
               if (res.result.ok === 1) return next(null, roles)
-
-              winston.warn(res.message)
-              return next(res.message)
+              else {
+                winston.warn(res.message)
+                return next(res.message)
+              }
+            } else {
+              return next('Unknown Error Occurred')
             }
           })
       },
@@ -104,9 +110,12 @@ function migrateUserRoles (callback) {
         userSchema.collection.updateMany({ role: 'user' }, { $set: { role: userRole._id } }).then(function (res) {
           if (res && res.result) {
             if (res.result.ok === 1) return next(null, roles)
-
-            winston.warn(res.message)
-            return next(res.message)
+            else {
+              winston.warn(res.message)
+              return next(res.message)
+            }
+          } else {
+            return next('Unknown Error Occurred')
           }
         })
       }