Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPP 1.1 CMP Cancels all auctions, do not fail if tcfapi also exists and gdpr applies #10245

Closed
patmmccann opened this issue Jul 19, 2023 · 1 comment · Fixed by #10282
Closed
Assignees
Labels

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 19, 2023

Closely related to #9483 ; however, the issue here is a GPP 1.1 CMP cancels all auctions following the logic here

function processCmpData(consentData, {onSuccess, onError}) {

The feature request is: while #9483 is being developed, if a 1.1 CMP is detected, do not fail when gdpr applies if the __tcfapi is also available. Please commit this feature to both legacy and 7.54.x. If #9483 is done, this becomes moot and this logic should be deleted from 8.x (but not legacy).

Test page and screenshot: https://www.derwesten.de/?pbjs_debug=true

image

User is aware they could choose not to configure gpp module when they have a gpp 1.1 cmp, but some users may experience a CMP upgrade without expecting it, and we're hoping they don't suddenly break.

@patmmccann patmmccann changed the title GPP 1.1 CMP Cancels all auctions GPP 1.1 CMP Cancels all auctions, do not fail if tcfapi also exists and gdpr applies Jul 19, 2023
@dgirardi
Copy link
Collaborator

if a 1.1 CMP is detected, do not fail when gdpr applies if the __tcfapi is also available

How about not failing if CMP version is not 1.0? I can't make sense of the gdpr condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants