Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair Id Module: generates multiple eids with same source #10479

Closed
patmmccann opened this issue Sep 13, 2023 · 1 comment · Fixed by #10488
Closed

Pair Id Module: generates multiple eids with same source #10479

patmmccann opened this issue Sep 13, 2023 · 1 comment · Fixed by #10488
Labels

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 13, 2023

Type of issue

Bug

Description

Google Pair module produces lots of distinct eids with the same source. They should be in a single object according to https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/2.x_official_extensions/eids.md

cc: @congdu-kun

Test page

Hard to reproduce, you have to have a lot of retargeting segments and be a Chrome user I think
firstquarterfinance.com is a site with the Pair module installed

Expected results

image

Actual results

image

This request is then rejected by PBS

@patmmccann patmmccann added the bug label Sep 13, 2023
@dgirardi
Copy link
Collaborator

They should be in a single object according to https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/2.x_official_extensions/eids.md

I cant' think of any way to read that spec that would warrant that conclusion. That spec does not say that there can be only one EID object per source, or that source must be unique across EID objects. What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants