-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for submitting fledge auction configs before GPT is ready #10566
Comments
Committee is favoring the second option and looking for additional feedback or consensus. cc: @JoelPM and @skoklowski |
We discussed further in committee, marking ready for dev |
Notes from the Identity PMC's 12/6 mtg regarding this topic.
The committee decided to move forward with option 2. Moving forward on option 2 requires attestation files. |
The offending line is the module is at Prebid.js/modules/fledgeForGpt.js Line 49 in 2493f98
And that's indeed the gap here with the module as it's written today. |
tagging @laurb9 for visibility |
Proposal:
We could also:
|
It would indeed be preferable to have the autoconfig logic be as smart as possible so that only the most advanced publisher setups require additional work. Along those lines -- given that the most async setups are already leveraging The goal IMO is to make it "just work" out of the box -- even if that means a few more configuration options via Thoughts? |
From #10477: Both Prebid.js and GPT scripts are asynchronous. We load them in parallel to speed up time when ads are displayed. Thanks to this approach it's more likely that user won't leave the page until ads are displayed. In addition Active View metric should be better.
I will try to describe this process. Let's assume that we need for example 2 seconds for loading GPT script and only 1 second to load Prebid.js script. Additionally we set for example 0.8 seconds as a timeout for Prebid standard auctions (in fact this is timeout for bidders to respond).
Our current approach
We start Prebid auction immediately without waiting for GPT script to load so we can start fetching ads from Google Ad Manager after 2 seconds - exactly the moment when GPT script is loaded because in this example Prebid needs only 1.8 seconds to do its job.
Your approach
You need to wait for GPT script to be fully loaded before running Prebid auction (I don't mean Protected Audience API auction but ordinary Prebid auction) because publisher are not able to define any slot before full GPT API is available (defineSlot function is not defined before that moment). So ads can be fetched after 2.8 seconds even though Prebid script was loaded after 1 second.
Solution
There are two ways to resolve issue mentioned above:
googletag.cmd.push(callback)
. This would change your code into asynchronous call - ascallback
has to be used. As far as I know it's not possible to do it in this specific fragment of Prebid code.Originally posted by @skoklowski in #10477 (comment)
The text was updated successfully, but these errors were encountered: