Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fledge configuration options #10573

Closed
dgirardi opened this issue Oct 4, 2023 · 1 comment
Closed

Rename fledge configuration options #10573

dgirardi opened this issue Oct 4, 2023 · 1 comment
Labels
9.0 API Change needs docs

Comments

@dgirardi
Copy link
Collaborator

dgirardi commented Oct 4, 2023

Type of issue

Improvement

Description

fledgeForGpt defines two top-level config options, fledgeEnabled and defaultForSlots. The latter has a very generic sounding name and should probably be scoped down to something like setConfig({fledge: {enabled: true, default: true}}). We can also consider renaming config and module to paapi if we are now past the codename stage.
@patmmccann
Copy link
Collaborator

I prefer to keep GPT in the name to distinguish from #9481

@dgirardi dgirardi mentioned this issue Jan 10, 2024
Merged
1 task
@dgirardi dgirardi mentioned this issue Jun 4, 2024
Merged
1 task
@dgirardi dgirardi mentioned this issue Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.0 API Change needs docs
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patmmccann @dgirardi @jdwieland8282