Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richaudience Bid Adapter: invalid responses on no bid #11044

Closed
Sir-Will opened this issue Feb 2, 2024 · 9 comments
Closed

Richaudience Bid Adapter: invalid responses on no bid #11044

Sir-Will opened this issue Feb 2, 2024 · 9 comments

Comments

@Sir-Will
Copy link
Contributor

Sir-Will commented Feb 2, 2024

Type of issue

Bug

Description

The bidder richaudience returns an invalid empty bid if there is no bid, this causes it to constantly log warnings and errors about it, and it's very irritating.
This doesn't seem to be a correct way of handling no bid, and it's the only bidder I have encountered it with.

Is there anything which can be done to stop this?

chrome_2024-02-02_14-58-32

@richaudience
Copy link
Contributor

Hi!
Sorry for this message of error, we know is very confused, but we're working on a new version to solve it.
This error is when the request returns one response that is not a JSON, this we do when in our endpoint detects any issue in the request.
I need to be able to update the adapter, but this issue blocks the pull request, please you can check as solved for the moment?
Cheers

@patmmccann
Copy link
Collaborator

patmmccann commented Feb 5, 2024

I need to be able to update the adapter, but this issue blocks the pull request, please you can check as solved for the moment?

This issue does not block you making a pull request to resolve it, please proceed with your solution. Fixing this is straightforward, and you should handle it within #11022 or independently, but before we continue to merge ongoing maintenance.

@patmmccann patmmccann added the bug label Feb 5, 2024
@patmmccann patmmccann changed the title richaudience error spam Richaudience Bid Adapter: invalid responses on no bid Feb 5, 2024
@patmmccann
Copy link
Collaborator

@richaudience please advise what your plan is here

@patmmccann
Copy link
Collaborator

@Sir-Will can you provide a link where this happens?

@patmmccann
Copy link
Collaborator

#11670

@Sir-Will
Copy link
Contributor Author

Sir-Will commented Jun 4, 2024

@Sir-Will can you provide a link where this happens?

Sorry for the delay. Not sure if it's still needed, but here is the adjusted demo: https://jsfiddle.net/0wfnt12z/4/

@richaudience
Copy link
Contributor

Hello,

We made a change to our bidding infrastructure this morning to resolve the issue mentioned in this ticket. Apologies for the delay.

@patmmccann, please let us know if any further changes are needed from our side.

In this demo you can see that it is working correctly: https://jsfiddle.net/60nw7gbs/1/

Thank you.

@patmmccann
Copy link
Collaborator

@Sir-Will @richaudience reports fixed, if so can you close out?

@patmmccann patmmccann reopened this Jun 19, 2024
@Sir-Will
Copy link
Contributor Author

I don't see the error anymore now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants